Fix compilation errors, upgrade Solidity #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grGred
reviewed
Aug 27, 2022
| }); | ||
|
|
||
| proposals[newProposal.id] = newProposal; | ||
| Proposal storage newProposal = proposals[proposalCount]; |
There was a problem hiding this comment.
This is incorrect since it doesn't create a new proprosal, but only creates link to a previous one.
You can test this
There was a problem hiding this comment.
Your test is using memory structs while this is using storage. This is effectively creating a pointer to the struct at the array index in storage and modifying the fields there, not copying anything.
grGred
reviewed
Aug 27, 2022
| @@ -292,7 +296,15 @@ contract GovernorBravoDelegate is GovernorBravoDelegateStorageV2, GovernorBravoE | |||
| * @return If the account is whitelisted | |||
| */ | |||
| function isWhitelisted(address account) public view returns (bool) { | |||
| return (whitelistAccountExpirations[account] > now); | |||
| uint currentBlockTimestamp = getBlockTimestamp(); | |||
There was a problem hiding this comment.
Strange idea, it would change nothing only making deployment gas cost increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in some changes from #208 to get the new GovernorBravoG2 contracts compileable, and updates the Solidity version to 0.8.15 (latest as of the time of this PR). There are a couple of breaking inheritance changes that required code changes here and here